Skip to content

remove unnecessary quotes in re-registration error message #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonpcouch opened this issue Sep 10, 2024 · 1 comment · Fixed by #1202
Closed

remove unnecessary quotes in re-registration error message #1201

simonpcouch opened this issue Sep 10, 2024 · 1 comment · Fixed by #1202
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

Some "" that don't appear to need to be there.

Code
set_fit(model = "bart", eng = "dbarts", mode = "regression", value = list(
interface = "data.frame", data = c(x = "x.train", y = "y.train"), protect = c(
"x", "y"), func = c(pkg = "dbarts", fun = "bart"), defaults = list(verbose = TRUE,
keeptrees = TRUE, keepcall = FALSE)))
Condition
Error in `set_fit()`:
! The combination of engine `dbarts` and mode `regression` "" already has fit data for model `bart` and the new information being registered is different.

Noticed this in the transition to snapshot testing in #1190.

@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Sep 10, 2024
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant