Skip to content

Commit 8f1054e

Browse files
authored
Fix reverse dependency issue with scale_backward_compatibility() (#6475)
1 parent 68ab7bf commit 8f1054e

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

R/scale-colour.R

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -298,18 +298,14 @@ scale_backward_compatibility <- function(..., scale, aesthetic, type) {
298298
scale <- scale %||% fallback
299299
}
300300

301-
if (is_bare_string(scale)) {
302-
if (scale == "continuous") {
303-
scale <- "gradient"
304-
}
305-
if (scale == "discrete") {
306-
scale <- "hue"
307-
}
308-
if (scale == "viridis") {
309-
scale <- switch(
310-
type, discrete = "viridis_d", binned = "viridis_b", "viridis_c"
311-
)
312-
}
301+
if (is_bare_string(scale) || is.null(scale)) {
302+
scale <- switch(
303+
scale %||% type,
304+
discrete = "hue",
305+
viridis = switch(type, discrete = "viridis_d", binned = "viridis_b", "viridis_c"),
306+
continuous = "gradient",
307+
scale
308+
)
313309

314310
candidates <- paste("scale", aesthetic, scale, sep = "_")
315311
for (candi in candidates) {

0 commit comments

Comments
 (0)