Skip to content

Commit 9816470

Browse files
authored
Correct mistake in #4775 (#4859)
1 parent 50e917a commit 9816470

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

R/scale-.r

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ ScaleContinuous <- ggproto("ScaleContinuous", Scale,
637637

638638
# Ensure limits don't exceed domain (#980)
639639
domain <- suppressWarnings(self$trans$transform(self$trans$domain))
640-
limits <- oob_squish(limits, domain)
640+
limits <- oob_squish(limits, sort(domain))
641641

642642
# Limits in transformed space need to be converted back to data space
643643
limits <- self$trans$inverse(limits)

tests/testthat/test-scales-breaks-labels.r

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,10 +372,13 @@ test_that("limits are squished to transformation domain", {
372372
# Breaks should not be calculated on ranges outside domain #980
373373
sc1 <- scale_x_sqrt()
374374
sc2 <- scale_x_sqrt()
375+
sc3 <- scale_x_reverse(breaks = 1:9) # Test for #4858
375376

376377
sc1$train(c(0, 10))
377378
sc2$train(c(-10, 10))
379+
sc3$train(c(0, -10)) # training expects transformed input
378380

379381
expect_equal(sc1$get_breaks(), sc2$get_breaks())
380382
expect_equal(sc2$get_breaks()[1], 0)
383+
expect_equal(sc3$get_breaks(), -1:-9)
381384
})

0 commit comments

Comments
 (0)