Skip to content

rlang dependency ahead of rlang itself #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonocarroll opened this issue Jul 16, 2018 · 5 comments
Closed

rlang dependency ahead of rlang itself #2759

jonocarroll opened this issue Jul 16, 2018 · 5 comments

Comments

@jonocarroll
Copy link
Contributor

Current dependence on rlang is >= 0.2.1

rlang (>= 0.2.1),

but rlang master branch is currently only at 0.2.0.9001

https://github.com/r-lib/rlang/blob/b4f810f1fba2e192ae09921b51441ac6a182970b/DESCRIPTION#L2

Needless to say, this breaks GitHub installs.

Is the intention to depend on another branch of rlang or is there a mismatch between DESCRIPTION file commits somewhere? The release-0.2.1 branch of rlang is actually much further out of date.

@jonocarroll
Copy link
Contributor Author

And now I see it's a known issue due to #2735 and noted in r-lib/rlang#549.

@jonocarroll
Copy link
Contributor Author

Thank you for the ⚡ fast fix. Greatly appreciated.

@lionel-
Copy link
Member

lionel- commented Jul 16, 2018

It actually comes 20 days late, thanks to @batpigandme for reminding me 😓

@jonocarroll
Copy link
Contributor Author

Given that there doesn't seem to be much noise made about it, perhaps it was a good time to have it slip through the cracks. Well I can now install the package which depends on ggplot2, so I'm quite thankful.

@lock
Copy link

lock bot commented Jan 12, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants