-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Consistency of handling a wrong length of parameter #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A related issue: The |
Basically, I agree with you!
I don't see any reason for now, but, if I understand correctly, Line 111 in 4a607ca
|
That's correct. However, I was talking about something else. I was suggesting that |
Oh, I read your comment wrong, sorry... Although it sounds good itself, I guess it's difficult to remove |
I didn't mean to propose to remove |
I mean, if One more question is, do you mean one can specify ggplot(df) +
geom_text(aes(x, y, nudge_y = 0.01 * sign(x), label = lab),
position = position_nudge(y = 0.1)) |
I made a PR (#3030) to explain what I mean. I see no technical problems. In either case, |
Thanks for the PR. I agree that there's no technical problems, but I still feel I'm not convinced... To be clear, I want to say |
No, it's not semantically wrong. In fact, I think it's needed. I just don't know how to implement it without completely rewriting layers. |
Hmm, then, I want to wait for the day when |
During reviewing #3024, I'm a bit confused to see multiple values are handled differently. I'm yet to find which behaviour is the supposed one.
nudge_x
andnudge_y
accept a different length of parameter w/ a warning.If the parameter is an aesthetic variable, it raises an error.
Some parameters just ignore multiple values (this seems because
gpar()
does so).Created on 2018-12-06 by the reprex package (v0.2.1)
The text was updated successfully, but these errors were encountered: