Skip to content

Review duplicated examples about multiple notations #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yutannihilation opened this issue Mar 8, 2019 · 2 comments · Fixed by #5676
Closed

Review duplicated examples about multiple notations #3181

yutannihilation opened this issue Mar 8, 2019 · 2 comments · Fixed by #5676

Comments

@yutannihilation
Copy link
Member

yutannihilation commented Mar 8, 2019

Some functions accept multiple ways of specification. It's useful to show that the multiple notations can generate the same results, but it's not necessary to execute all the examples. In order to reduce the check time, we need to restructure these examples (e.g. commenting out the less promoted notations)

  • anonymous functions (function(x) vs ~)
    • stat_function()
  • facet specs (vars() vs ~ vs character)
    • facet_wrap()
    • facet_grid()

For anonymous functions, I think we should wait for ggplot2 to get support for ~ notation in all the places that accept functions.

@clauswilke
Copy link
Member

Let's enumerate the functions that this applies to. Of the top of my head, I can think of:

  • stat_function()
  • facet_wrap()
  • facet_grid()

Something else?

@yutannihilation
Copy link
Member Author

Thanks. At the moment, they are exactly what I'm thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants