Skip to content

@import rlang? #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yutannihilation opened this issue Mar 19, 2019 · 5 comments · Fixed by #3242
Closed

@import rlang? #3195

yutannihilation opened this issue Mar 19, 2019 · 5 comments · Fixed by #3242
Labels
internals 🔎
Milestone
ggplot2 3.2.0

Comments

@yutannihilation
Copy link
Member

Lionel said:

Our default practice is to import the whole rlang package and use the non-qualified form.

If it's a common practice among tidyverse, I think we should follow it. It is probably good for performance (though I'm not sure how much it matters).
@hadley
Copy link
Member

hadley commented Mar 21, 2019

Agreed

@yutannihilation
Copy link
Member Author

yutannihilation commented Mar 22, 2019 •
edited
Loading

OK, then I will do this after the existing big PRs get merged.

@thomasp85
Copy link
Member

@yutannihilation which PRs were you referencing? Can this be done now?

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 11, 2019
@yutannihilation
Copy link
Member Author

Will do. But, I'm sure the PR will conflict with others, and I'm afraid I won't have much time for fixing it immediately this month. Feel free to take over if you feel I'm not responsive!

@yutannihilation yutannihilation mentioned this issue Apr 13, 2019
Merged
@lock
Copy link

lock bot commented Oct 20, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
internals 🔎
Projects
None yet
Milestone
ggplot2 3.2.0
Development

Successfully merging a pull request may close this issue.

Import rlang and use unqualified form for rlang functions yutannihilation/ggplot2
3 participants
@hadley @thomasp85 @yutannihilation