Skip to content

Downstream packages that subclass position scales need updating #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paleolimbot opened this issue Oct 10, 2019 · 4 comments
Closed

Downstream packages that subclass position scales need updating #3565

paleolimbot opened this issue Oct 10, 2019 · 4 comments

Comments

@paleolimbot
Copy link
Member

Only two packages subclassing a position scale were identified in the revdeps because they failed for other reasons...position scale subclasses won't error but will instead hide the subclassed position scale (as previously the only correct guide value was "none" for a position scale). These packages need to update guide property on position scale subclasses to waiver(), or axes will stop being displayed after #3356. This will have to be version dependent, as older code does not ignore position aesthetics when building guides. This is the case with dint and ggforce (here and here).

Transformations in position scales must handle NA values after #3398 (which allows NA values in coordinate system limits), which is a problem for one package (dint).

@yutannihilation yutannihilation added this to the ggplot2 3.3.0 milestone Dec 18, 2019
@clauswilke
Copy link
Member

@paleolimbot Have issues been filed with the afflicted packages? I ran into the dint issue the other day.

@paleolimbot
Copy link
Member Author

Done! See s-fleck/dint#3 and thomasp85/ggforce#188 .

@paleolimbot
Copy link
Member Author

Are you aware of any other packages that might be affected? I checked bench, but it doesn't call continuous_scale() directly and its transforms handle NAs.

@clauswilke
Copy link
Member

I'm not. I ran into the dint issue by accident, when I needed a date scale in quarters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants