Skip to content

stat_binhex() fails to notify users that they need to install hexbin package #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yutannihilation opened this issue Feb 20, 2022 · 2 comments
Closed

stat_binhex() fails to notify users that they need to install hexbin package #4736

yutannihilation opened this issue Feb 20, 2022 · 2 comments
Labels
bug an unexpected problem or unintended behavior help wanted ❤️ we'd love your help! layers 📈
Milestone
ggplot2 3.4.0

Comments

@yutannihilation
Copy link
Member

#4671 (comment)

I can reproduce this on my local without hexbin installed.

> library(ggplot2)
> d <- ggplot(diamonds, aes(carat, price))
> d + geom_hex()
Warning message:
Computation failed in `stat_binhex()`:

I think this is because check_installed is inside compute_group, where the error is ignored.

ggplot2/R/stat-binhex.r

Line 52 in c89c265

check_installed("hexbin", reason = "for `stat_binhex()`")

@yutannihilation yutannihilation mentioned this issue Feb 20, 2022
Merged
@hadley hadley added bug an unexpected problem or unintended behavior layers 📈 help wanted ❤️ we'd love your help! labels Mar 14, 2022
@yutannihilation yutannihilation mentioned this issue Apr 28, 2022
Closed
@yutannihilation
Copy link
Member Author

Related: #4843

@yutannihilation yutannihilation mentioned this issue May 14, 2022
Closed
@yutannihilation yutannihilation added this to the ggplot2 3.4.0 milestone May 21, 2022
@yutannihilation
Copy link
Member Author

Resolved by #4856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior help wanted ❤️ we'd love your help! layers 📈
Projects
None yet
Milestone
ggplot2 3.4.0
Development

Successfully merging a pull request may close this issue.

Propagate errors from check_installed() yutannihilation/ggplot2
2 participants
@hadley @yutannihilation