From c52e7cff90a92e1ab0aae50d2472f56f38abba2a Mon Sep 17 00:00:00 2001 From: Kara Woo Date: Mon, 19 Jun 2017 15:16:00 -0700 Subject: [PATCH 1/3] Add test for theme_linedraw() --- tests/figs/themes/theme-linedraw.svg | 92 ++++++++++++++++++++++++++++ tests/testthat/test-theme.r | 1 + 2 files changed, 93 insertions(+) create mode 100644 tests/figs/themes/theme-linedraw.svg diff --git a/tests/figs/themes/theme-linedraw.svg b/tests/figs/themes/theme-linedraw.svg new file mode 100644 index 0000000000..8f7a7ba730 --- /dev/null +++ b/tests/figs/themes/theme-linedraw.svg @@ -0,0 +1,92 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +1 + + + + + + + + + + +1.0 +1.5 +2.0 +2.5 +3.0 +1.0 +1.5 +2.0 +2.5 +3.0 + + + + + +x +y + +z + + + + +a +b +theme_linedraw + diff --git a/tests/testthat/test-theme.r b/tests/testthat/test-theme.r index 4355033e23..7b3da1d4f6 100644 --- a/tests/testthat/test-theme.r +++ b/tests/testthat/test-theme.r @@ -250,5 +250,6 @@ test_that("themes don't change without acknowledgement", { vdiffr::expect_doppelganger("theme_gray", plot + theme_gray()) vdiffr::expect_doppelganger("theme_light", plot + theme_light()) vdiffr::expect_doppelganger("theme_void", plot + theme_void()) + vdiffr::expect_doppelganger("theme_linedraw", plot + theme_linedraw()) }) From 45d787eb30ff48387025ac4c6e775c0bdcd18bc9 Mon Sep 17 00:00:00 2001 From: Kara Woo Date: Mon, 19 Jun 2017 15:24:44 -0700 Subject: [PATCH 2/3] Add test for theme_test() --- tests/figs/themes/theme-test.svg | 74 ++++++++++++++++++++++++++++++++ tests/testthat/test-theme.r | 1 + 2 files changed, 75 insertions(+) create mode 100644 tests/figs/themes/theme-test.svg diff --git a/tests/figs/themes/theme-test.svg b/tests/figs/themes/theme-test.svg new file mode 100644 index 0000000000..c9a7a91b90 --- /dev/null +++ b/tests/figs/themes/theme-test.svg @@ -0,0 +1,74 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + +1 + + + + + + + + + + +1.0 +1.5 +2.0 +2.5 +3.0 +1.0 +1.5 +2.0 +2.5 +3.0 + + + + + +x +y + +z + + + + +a +b +theme_test + diff --git a/tests/testthat/test-theme.r b/tests/testthat/test-theme.r index 7b3da1d4f6..2f785bbc5b 100644 --- a/tests/testthat/test-theme.r +++ b/tests/testthat/test-theme.r @@ -251,5 +251,6 @@ test_that("themes don't change without acknowledgement", { vdiffr::expect_doppelganger("theme_light", plot + theme_light()) vdiffr::expect_doppelganger("theme_void", plot + theme_void()) vdiffr::expect_doppelganger("theme_linedraw", plot + theme_linedraw()) + vdiffr::expect_doppelganger("theme_test", plot + theme_test()) }) From ce3414a537a024eab569bde887b6eb9e46df7400 Mon Sep 17 00:00:00 2001 From: Kara Woo Date: Mon, 19 Jun 2017 15:42:13 -0700 Subject: [PATCH 3/3] Revert "Add test for theme_test()" This reverts commit 45d787eb30ff48387025ac4c6e775c0bdcd18bc9. --- tests/figs/themes/theme-test.svg | 74 -------------------------------- tests/testthat/test-theme.r | 1 - 2 files changed, 75 deletions(-) delete mode 100644 tests/figs/themes/theme-test.svg diff --git a/tests/figs/themes/theme-test.svg b/tests/figs/themes/theme-test.svg deleted file mode 100644 index c9a7a91b90..0000000000 --- a/tests/figs/themes/theme-test.svg +++ /dev/null @@ -1,74 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - -1 - - - - - - - - - - -1.0 -1.5 -2.0 -2.5 -3.0 -1.0 -1.5 -2.0 -2.5 -3.0 - - - - - -x -y - -z - - - - -a -b -theme_test - diff --git a/tests/testthat/test-theme.r b/tests/testthat/test-theme.r index 2f785bbc5b..7b3da1d4f6 100644 --- a/tests/testthat/test-theme.r +++ b/tests/testthat/test-theme.r @@ -251,6 +251,5 @@ test_that("themes don't change without acknowledgement", { vdiffr::expect_doppelganger("theme_light", plot + theme_light()) vdiffr::expect_doppelganger("theme_void", plot + theme_void()) vdiffr::expect_doppelganger("theme_linedraw", plot + theme_linedraw()) - vdiffr::expect_doppelganger("theme_test", plot + theme_test()) })