Skip to content

Typescript 1.7.3 appears to break config loading #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asakusuma opened this issue Dec 1, 2015 · 5 comments
Closed

Typescript 1.7.3 appears to break config loading #7

asakusuma opened this issue Dec 1, 2015 · 5 comments

Comments

@asakusuma
Copy link
Contributor

Neither of these functions appear to exist in 1.7.3: ts.parseConfigFile() ts.convertCompilerOptionsFromJson
https://github.com/tildeio/broccoli-typescript-compiler/blob/master/index.js#L46-L49

"Cannot load tsconfig.json from ..." gets thrown

@DanielRosenwasser
Copy link

Sorry about that - I think we renamed the parseConfigFile function in 1.7 to parseJsonConfigFileContent. Can you make that change and give it a try?

Though, convertCompilerOptionsFromJson should be present.

@asakusuma
Copy link
Contributor Author

Yep, I'll take a stab at a PR here. Thanks.

@rwjblue
Copy link
Collaborator

rwjblue commented Dec 2, 2015

@DanielRosenwasser - Was parseConfigFile considered private API? If yes, what can we do to ensure we are using public/supported API's here (and avoid minor version breakage like this in the future)?

@DanielRosenwasser
Copy link

I don't think it was a private API. I just documented the break on https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-17, but we're sorry it slipped under the radar.

@rwjblue
Copy link
Collaborator

rwjblue commented Dec 2, 2015

@DanielRosenwasser - Ya, no real worries, I just am ramping up to speed to help maintain here and thought that we might need to figure out a better / more supported path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants