Skip to content

Improve debug info to show function arguments in stack traces #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2019

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented May 13, 2019

Improve debug information (see commit). Also, implement comparing channel values (found while working on this).

This commit adds debug info to function arguments, so that in many cases
you can see them when compiling with less optimizations enabled.
Unfortunately, due to the way Go SSA works, it is hard to preserve them
in many cases.
Local variables are not yet saved.

Also, change the language type to C, to make sure lldb shows function
arguments. The previous language was Modula 3, apparently due to a
off-by-one error somewhere.

aykevl added 2 commits May 13, 2019 20:35
This commit adds debug info to function arguments, so that in many cases
you can see them when compiling with less optimizations enabled.
Unfortunately, due to the way Go SSA works, it is hard to preserve them
in many cases.
Local variables are not yet saved.

Also, change the language type to C, to make sure lldb shows function
arguments. The previous language was Modula 3, apparently due to a
off-by-one error somewhere.
@aykevl aykevl changed the title Debuginfo args Improve debug info to show function arguments in stack traces May 13, 2019
@aykevl
Copy link
Member Author

aykevl commented May 13, 2019

This was very useful while working on #347. It allows inspection of arguments in stack traces, even the internals of map objects for example (they are implemented as *runtime.hashmap and should be treated as pointers in the debugger).

@deadprogram
Copy link
Member

Good progress! Now merging.

@deadprogram deadprogram merged commit 371c468 into dev May 14, 2019
@deadprogram deadprogram deleted the debuginfo-args branch May 14, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants