Skip to content
This repository was archived by the owner on Aug 21, 2020. It is now read-only.

Flunks go vet #4

Closed
ryboe opened this issue Apr 10, 2017 · 3 comments
Closed

Flunks go vet #4

ryboe opened this issue Apr 10, 2017 · 3 comments
Labels

Comments

@ryboe
Copy link
Contributor

ryboe commented Apr 10, 2017

$ go vet $(go list ./... | grep -v /vendor/)  # avoid scanning vendor/
header.go:71: +build comment must appear before package clause and be followed by a blank line
@tmthrgd
Copy link
Owner

tmthrgd commented Apr 10, 2017

This is actually a bug in go vet not in go-bindata. That build comment is inside a string literal (see header.go:71) and is part of the generated output.

While it is possible to silence this warning with a hack, I'd much rather not. I'll leave this open and marked wontfix, and I'll submit a bug report for go vet and see if that can be fixed.

@tmthrgd
Copy link
Owner

tmthrgd commented Apr 10, 2017

The go vet bug has already been reported in golang/go#12269 and golang/go#13533. The first was closed with the given reason "Not worth the trouble to fix." The second has also been closed with the given reason "probably not worth doing".

Unless you have a particularly pressing reason to address this, I think I'd rather leave it as wontfix.

@tmthrgd
Copy link
Owner

tmthrgd commented Apr 11, 2017

I reneged, and I fixed it in d825d59 with a small workaround.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants