Skip to content

Commit 6a7a883

Browse files
kyriewu-hwmchehab
authored andcommitted
media: mtk-jpeg: Remove some unnecessary variables
remove is_jpgenc_multihw, is_jpgdec_multihw, and unnecessary initialization. Signed-off-by: kyrie wu <[email protected]> Signed-off-by: irui wang <[email protected]> Signed-off-by: Hans Verkuil <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent d40e952 commit 6a7a883

File tree

3 files changed

+18
-33
lines changed

3 files changed

+18
-33
lines changed

drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,10 @@ struct mtk_jpegdec_comp_dev {
204204
* @variant: driver variant to be used
205205
* @reg_encbase: jpg encode register base addr
206206
* @enc_hw_dev: jpg encode hardware device
207-
* @is_jpgenc_multihw: the flag of multi-hw core
208207
* @enc_hw_wq: jpg encode wait queue
209208
* @enchw_rdy: jpg encode hw ready flag
210209
* @reg_decbase: jpg decode register base addr
211210
* @dec_hw_dev: jpg decode hardware device
212-
* @is_jpgdec_multihw: the flag of dec multi-hw core
213211
* @dec_hw_wq: jpg decode wait queue
214212
* @dec_workqueue: jpg decode work queue
215213
* @dechw_rdy: jpg decode hw ready flag
@@ -229,13 +227,11 @@ struct mtk_jpeg_dev {
229227

230228
void __iomem *reg_encbase[MTK_JPEGENC_HW_MAX];
231229
struct mtk_jpegenc_comp_dev *enc_hw_dev[MTK_JPEGENC_HW_MAX];
232-
bool is_jpgenc_multihw;
233230
wait_queue_head_t enc_hw_wq;
234231
atomic_t enchw_rdy;
235232

236233
void __iomem *reg_decbase[MTK_JPEGDEC_HW_MAX];
237234
struct mtk_jpegdec_comp_dev *dec_hw_dev[MTK_JPEGDEC_HW_MAX];
238-
bool is_jpgdec_multihw;
239235
wait_queue_head_t dec_hw_wq;
240236
struct workqueue_struct *dec_workqueue;
241237
atomic_t dechw_rdy;

drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -608,23 +608,18 @@ static int mtk_jpegdec_hw_probe(struct platform_device *pdev)
608608
dev->plat_dev = pdev;
609609
dev->dev = &pdev->dev;
610610

611-
if (!master_dev->is_jpgdec_multihw) {
612-
master_dev->is_jpgdec_multihw = true;
613-
for (i = 0; i < MTK_JPEGDEC_HW_MAX; i++)
614-
master_dev->dec_hw_dev[i] = NULL;
615-
616-
init_waitqueue_head(&master_dev->dec_hw_wq);
617-
master_dev->workqueue = alloc_ordered_workqueue(MTK_JPEG_NAME,
618-
WQ_MEM_RECLAIM
619-
| WQ_FREEZABLE);
620-
if (!master_dev->workqueue)
621-
return -EINVAL;
622-
623-
ret = devm_add_action_or_reset(&pdev->dev, mtk_jpegdec_destroy_workqueue,
624-
master_dev->workqueue);
625-
if (ret)
626-
return ret;
627-
}
611+
init_waitqueue_head(&master_dev->dec_hw_wq);
612+
master_dev->workqueue = alloc_ordered_workqueue(MTK_JPEG_NAME,
613+
WQ_MEM_RECLAIM
614+
| WQ_FREEZABLE);
615+
if (!master_dev->workqueue)
616+
return -EINVAL;
617+
618+
ret = devm_add_action_or_reset(&pdev->dev,
619+
mtk_jpegdec_destroy_workqueue,
620+
master_dev->workqueue);
621+
if (ret)
622+
return ret;
628623

629624
atomic_set(&master_dev->dechw_rdy, MTK_JPEGDEC_HW_MAX);
630625
spin_lock_init(&dev->hw_lock);

drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -340,18 +340,12 @@ static int mtk_jpegenc_hw_probe(struct platform_device *pdev)
340340
dev->plat_dev = pdev;
341341
dev->dev = &pdev->dev;
342342

343-
if (!master_dev->is_jpgenc_multihw) {
344-
master_dev->is_jpgenc_multihw = true;
345-
for (i = 0; i < MTK_JPEGENC_HW_MAX; i++)
346-
master_dev->enc_hw_dev[i] = NULL;
347-
348-
init_waitqueue_head(&master_dev->enc_hw_wq);
349-
master_dev->workqueue = alloc_ordered_workqueue(MTK_JPEG_NAME,
350-
WQ_MEM_RECLAIM
351-
| WQ_FREEZABLE);
352-
if (!master_dev->workqueue)
353-
return -EINVAL;
354-
}
343+
init_waitqueue_head(&master_dev->enc_hw_wq);
344+
master_dev->workqueue = alloc_ordered_workqueue(MTK_JPEG_NAME,
345+
WQ_MEM_RECLAIM
346+
| WQ_FREEZABLE);
347+
if (!master_dev->workqueue)
348+
return -EINVAL;
355349

356350
atomic_set(&master_dev->enchw_rdy, MTK_JPEGENC_HW_MAX);
357351
spin_lock_init(&dev->hw_lock);

0 commit comments

Comments
 (0)