Skip to content

Commit 766338c

Browse files
vladimirolteankuba-moo
authored andcommitted
net: enetc: rename "xdp" and "dev" in enetc_setup_bpf()
Follow the convention from this driver, which is to name "struct net_device *" as "ndev", and the convention from other drivers, to name "struct netdev_bpf *" as "bpf". Signed-off-by: Vladimir Oltean <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5093406 commit 766338c

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

drivers/net/ethernet/freescale/enetc/enetc.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2586,20 +2586,20 @@ int enetc_setup_tc_mqprio(struct net_device *ndev, void *type_data)
25862586
return 0;
25872587
}
25882588

2589-
static int enetc_setup_xdp_prog(struct net_device *dev, struct bpf_prog *prog,
2589+
static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog,
25902590
struct netlink_ext_ack *extack)
25912591
{
2592-
struct enetc_ndev_priv *priv = netdev_priv(dev);
2592+
struct enetc_ndev_priv *priv = netdev_priv(ndev);
25932593
struct bpf_prog *old_prog;
25942594
bool is_up;
25952595
int i;
25962596

25972597
/* The buffer layout is changing, so we need to drain the old
25982598
* RX buffers and seed new ones.
25992599
*/
2600-
is_up = netif_running(dev);
2600+
is_up = netif_running(ndev);
26012601
if (is_up)
2602-
dev_close(dev);
2602+
dev_close(ndev);
26032603

26042604
old_prog = xchg(&priv->xdp_prog, prog);
26052605
if (old_prog)
@@ -2617,16 +2617,16 @@ static int enetc_setup_xdp_prog(struct net_device *dev, struct bpf_prog *prog,
26172617
}
26182618

26192619
if (is_up)
2620-
return dev_open(dev, extack);
2620+
return dev_open(ndev, extack);
26212621

26222622
return 0;
26232623
}
26242624

2625-
int enetc_setup_bpf(struct net_device *dev, struct netdev_bpf *xdp)
2625+
int enetc_setup_bpf(struct net_device *ndev, struct netdev_bpf *bpf)
26262626
{
2627-
switch (xdp->command) {
2627+
switch (bpf->command) {
26282628
case XDP_SETUP_PROG:
2629-
return enetc_setup_xdp_prog(dev, xdp->prog, xdp->extack);
2629+
return enetc_setup_xdp_prog(ndev, bpf->prog, bpf->extack);
26302630
default:
26312631
return -EINVAL;
26322632
}

drivers/net/ethernet/freescale/enetc/enetc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ struct net_device_stats *enetc_get_stats(struct net_device *ndev);
415415
void enetc_set_features(struct net_device *ndev, netdev_features_t features);
416416
int enetc_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd);
417417
int enetc_setup_tc_mqprio(struct net_device *ndev, void *type_data);
418-
int enetc_setup_bpf(struct net_device *dev, struct netdev_bpf *xdp);
418+
int enetc_setup_bpf(struct net_device *ndev, struct netdev_bpf *bpf);
419419
int enetc_xdp_xmit(struct net_device *ndev, int num_frames,
420420
struct xdp_frame **frames, u32 flags);
421421

0 commit comments

Comments
 (0)