Skip to content

Commit 2f96814

Browse files
committed
fix filtering of provisionalScoreComplete logic
1 parent 5e470c6 commit 2f96814

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

config/development.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "68c5a381-c8ab-48af-92a7-7a869a4ee6c3",
3-
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "df51ca7d-fb0a-4147-9569-992fcf5aae48"
3+
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "52c91e85-745f-4e62-b592-9879a2dfe9fd"
44
}

config/production.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
3-
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": ""
3+
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "df51ca7d-fb0a-4147-9569-992fcf5aae48"
44
}

src/utils/submission.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ export function processMMSubmissions(submissions, resources, registrants) {
144144

145145
const provisionalScoringIsCompleted = _.some(
146146
submission.review,
147-
{ id: PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID },
147+
{ typeId: PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID },
148148
);
149+
149150
const provisionalScore = toFixed(_.get(validReviews, '[0].score', '-'), 5);
150151
const finalScore = toFixed(_.get(submission, 'reviewSummation[0].aggregateScore', '-'), 5);
151152

0 commit comments

Comments
 (0)