fix replacement of sections with dash (#2000)

Co-authored-by: Jürgen Gmach <[email protected]>
Co-authored-by: Miroslav Šedivý <[email protected]>

Author: 3 people

docs/changelog/1985.bugfix.rst

@@ -0,0 +1,2 @@
+Enable replacements (a.k.a section substitions) for section names containing a dash in sections
+without the ``testenv:`` prefix - by :user:`jugmac00`, :user:`obestwalter`, :user:`eumiro`.

src/tox/config/loader/ini/replace.py

@@ -89,7 +89,7 @@ def _replace_match(
 
 _REPLACE_REF = re.compile(
     rf"""
-    (\[(?P<full_env>{BASE_TEST_ENV}(:(?P<env>[^]]+))?|(?P<section>\w+))\])? # env/section
+    (\[(?P<full_env>{BASE_TEST_ENV}(:(?P<env>[^]]+))?|(?P<section>[-\w]+))\])? # env/section
     (?P<key>[a-zA-Z0-9_]+) # key
     (:(?P<default>.*))? # default value
 """,

tests/config/loader/ini/replace/test_replace_tox_env.py

@@ -151,3 +151,18 @@ def test_replace_from_tox_other_tox_section_same_name(tox_ini_conf: ToxIniCreato
     conf_a = tox_ini_conf("[testenv:a]\nx={[testenv:b]c}\nc=d\n[testenv:b]}").get_env("a")
     conf_a.add_config(keys="x", of_type=str, default="", desc="d")
     assert conf_a["x"] == "{[testenv:b]c}"
+
+
+@pytest.mark.parametrize(
+    ("env_name", "exp"),
+    [
+        ("testenv:foobar", "1"),
+        ("testenv:foo-bar", "1"),
+        ("foo-bar", "1"),
+        ("foobar", "1"),
+    ],
+)
+def test_replace_valid_section_names(tox_ini_conf: ToxIniCreator, env_name: str, exp: str) -> None:
+    conf_a = tox_ini_conf(f"[{env_name}]\na={exp}\n[testenv:a]\nx = {{[{env_name}]a}}").get_env("a")
+    conf_a.add_config(keys="x", of_type=str, default="o", desc="o")
+    assert conf_a["x"] == exp