Skip to content

Commit a1cf66c

Browse files
authored
#466 stop env var leakage if popen failed with resultjson or redirect (#626)
1 parent 31a7c22 commit a1cf66c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tox/session.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ def popen(self, args, cwd=None, env=None, redirect=True, returnout=False, ignore
122122
resultjson = self.session.config.option.resultjson
123123
if resultjson or redirect:
124124
fout = self._initlogpath(self.id)
125-
fout.write("actionid: %s\nmsg: %s\ncmdargs: %r\nenv: %s\n\n" % (
126-
self.id, self.msg, args, env))
125+
fout.write("actionid: %s\nmsg: %s\ncmdargs: %r\n\n" % (self.id, self.msg, args))
127126
fout.flush()
128127
self.popen_outpath = outpath = py.path.local(fout.name)
129128
fin = outpath.open()

0 commit comments

Comments
 (0)