[SE-0364] Handle retroactive conformance for types and protocols from underlying modules.

SE-0364 was implemented to discourage "retroactive" conformances that might
conflict with conformances that could be introduced by other modules in the
future. These diagnostics should not apply to conformances that involve types
and protocols imported from the underlying clang module of a Swift module since
the two modules are assumed to be developed in tandem by the same owners,
despite technically being separate modules from the perspective of the
compiler.

The diagnostics implemented in swiftlang#36068 were
designed to take underlying clang modules into account. However, the
implementation assumed that `ModuleDecl::getUnderlyingModuleIfOverlay()` would
behave as expected when called on the Swift module being compiled.
Unfortunately, it would always return `nullptr` and thus conformances involving
the underlying clang module are being diagnosed unexpectedly.

The fix is to make `ModuleDecl::getUnderlyingModuleIfOverlay()` behave as
expected when it is made up of `SourceFile`s.

Resolves rdar://121478556

Author: tshortli

include/swift/AST/SourceFile.h

@@ -144,6 +144,9 @@ class SourceFile final : public FileUnit {
   /// This is \c None until it is filled in by the import resolution phase.
   llvm::Optional<ArrayRef<AttributedImport<ImportedModule>>> Imports;
 
+  /// The underlying clang module, if imported in this file.
+  ModuleDecl *ImportedUnderlyingModule = nullptr;
+
   /// Which imports have made use of @preconcurrency.
   llvm::SmallDenseSet<AttributedImport<ImportedModule>>
       PreconcurrencyImportsUsed;
@@ -693,6 +696,17 @@ class SourceFile final : public FileUnit {
     return isScriptMode() || hasMainDecl();
   }
 
+  ModuleDecl *getUnderlyingModuleIfOverlay() const override {
+    return ImportedUnderlyingModule;
+  }
+
+  const clang::Module *getUnderlyingClangModule() const override {
+    if (!ImportedUnderlyingModule)
+      return nullptr;
+
+    return ImportedUnderlyingModule->findUnderlyingClangModule();
+  }
+
   /// Get the root refinement context for the file. The root context may be
   /// null if the context hierarchy has not been built yet. Use
   /// TypeChecker::getOrBuildTypeRefinementContext() to get a built

lib/AST/Module.cpp

@@ -2566,6 +2566,20 @@ void
 SourceFile::setImports(ArrayRef<AttributedImport<ImportedModule>> imports) {
   assert(!Imports && "Already computed imports");
   Imports = getASTContext().AllocateCopy(imports);
+
+  // Find and cache the import of the underlying module, if present.
+  auto parentModuleName = getParentModule()->getName();
+  for (auto import : imports) {
+    if (!import.options.contains(ImportFlags::Exported))
+      continue;
+
+    auto importedModule = import.module.importedModule;
+    if (importedModule->getName() == parentModuleName &&
+        importedModule->findUnderlyingClangModule()) {
+      ImportedUnderlyingModule = import.module.importedModule;
+      break;
+    }
+  }
 }
 
 bool SourceFile::hasImportUsedPreconcurrency(

lib/AST/ModuleDependencies.cpp

@@ -438,8 +438,6 @@ swift::dependencies::checkImportNotTautological(const ImportPath::Module moduleP
                        filename, modulePath.front().Item);
 
   return false;
-
-  return false;
 }
 
 void SwiftDependencyTracker::addCommonSearchPathDeps(

test/Inputs/clang-importer-sdk/swift-modules/ObjectiveC.swift

@@ -82,7 +82,7 @@ public func ~=(x: NSObject, y: NSObject) -> Bool {
   return true
 }
 
-extension NSObject : @retroactive Equatable, @retroactive Hashable {
+extension NSObject : Equatable, Hashable {
   public static func == (lhs: NSObject, rhs: NSObject) -> Bool {
     return lhs.isEqual(rhs)
   }

test/Sema/extension_retroactive_conformances_underlying_clang_module.swift

@@ -0,0 +1,49 @@
+// RUN: %empty-directory(%t)
+// RUN: split-file %s %t
+// RUN: %target-swift-frontend -swift-version 5 %t/OtherLibrary.swift -emit-module -module-name OtherLibrary -o %t
+// RUN: %target-swift-frontend -typecheck %t/Library.swift -module-name Library -verify -swift-version 5 -import-underlying-module -I %t
+// RUN: %target-swift-frontend -typecheck %t/Library.swift -module-name Library -verify -swift-version 5 -DEXPLICIT_IMPORT -I %t
+
+// REQUIRES: objc_interop
+
+//--- module.modulemap
+
+module Library {
+  header "Library.h"
+}
+
+//--- Library.h
+
+@import Foundation;
+
+@interface UnderlyingLibraryClass : NSObject
+@end
+
+@protocol UnderlyingLibraryProtocol
+@end
+
+//--- OtherLibrary.swift
+
+public class OtherLibraryClass {}
+public protocol OtherLibraryProtocol {}
+
+//--- Library.swift
+
+#if EXPLICIT_IMPORT
+@_exported import Library
+#endif
+import OtherLibrary
+
+public class LibraryClass {}
+public protocol LibraryProtocol {}
+
+extension LibraryClass: UnderlyingLibraryProtocol {}
+extension LibraryClass: LibraryProtocol {}
+extension LibraryClass: OtherLibraryProtocol {}
+extension UnderlyingLibraryClass: OtherLibraryProtocol {}
+extension UnderlyingLibraryClass: LibraryProtocol {}
+extension UnderlyingLibraryClass: UnderlyingLibraryProtocol {}
+extension OtherLibraryClass: UnderlyingLibraryProtocol {}
+extension OtherLibraryClass: LibraryProtocol {}
+extension OtherLibraryClass: OtherLibraryProtocol {} // expected-warning {{extension declares a conformance of imported type 'OtherLibraryClass' to imported protocol 'OtherLibraryProtocol'}}
+// expected-note @-1 {{add '@retroactive' to silence this warning}} {{30-50=@retroactive OtherLibraryProtocol}}