Skip to content

Slices of Into<NodeId> unsound #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
molpopgen opened this issue Jan 23, 2023 · 2 comments
Closed

Slices of Into<NodeId> unsound #446

molpopgen opened this issue Jan 23, 2023 · 2 comments
Labels
safety
Milestone
0.14.0

Comments

@molpopgen
Copy link
Member

A few functions take &[T] where T: Into<NodeId>. The intent is to support client code working with tsk_id_t, but the trait bound in unsound. It is possible for a type to implement Into<NodeId> but not have the same ABI as NodeId.
@molpopgen molpopgen reopened this Jan 25, 2023
@molpopgen molpopgen added this to the 0.13.0 milestone Jan 31, 2023
@molpopgen
Copy link
Member Author

It looks like the only instance of this was in TableCollection::simplify and was fixed in #465.

I will close for now, but we can reopen later as needed.

@molpopgen molpopgen reopened this Mar 15, 2023
@molpopgen molpopgen modified the milestones: 0.13.0, 0.14.0 Mar 16, 2023
@molpopgen
Copy link
Member Author

closed by #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
safety
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
1 participant
@molpopgen