Skip to content

Internal type related to edge difference iterator implements Deref/DerefMut #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
molpopgen opened this issue Jan 26, 2023 · 1 comment · Fixed by #451
Closed

Internal type related to edge difference iterator implements Deref/DerefMut #450

molpopgen opened this issue Jan 26, 2023 · 1 comment · Fixed by #451
Labels
API API. issues

Comments

@molpopgen
Copy link
Member

molpopgen commented Jan 26, 2023 •
edited
Loading

There is no need for this.
I suspect this was done during development and never removed.

Removing the impl is not breaking as the types in question are not public.
@molpopgen molpopgen added API API. issues API breaking Issues/PRs that may break API. labels Jan 26, 2023
@molpopgen molpopgen changed the title Edge difference iterator implements Deref/DerefMut Internal type implements Deref/DerefMut Jan 26, 2023
@molpopgen molpopgen mentioned this issue Jan 26, 2023
Merged
@molpopgen molpopgen reopened this Mar 15, 2023
@molpopgen molpopgen changed the title Internal type implements Deref/DerefMut Internal type related to edge difference iterator implements Deref/DerefMut Mar 15, 2023
@molpopgen molpopgen removed the API breaking Issues/PRs that may break API. label Mar 16, 2023
@molpopgen
Copy link
Member Author

closed by #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API API. issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove impl Deref/DerefMut for LLEdgeDifferencesIterator tskit-dev/tskit-rust
1 participant
@molpopgen