Support storing 64 bit offsets #1571
Conversation
jeromekelleher
force-pushed
the
variable-size-offsets
branch
from
100e647 to
ad02ac7
Compare
|
I think this is ready for review @benjeffery - it doesn't affect any existing behaviour, so should be OK to merge I think. |
|
Ah, crap, the 64 bit BIG_TABLE tests aren't going to work. I think it's probably simplest to disable these for a few days until the follow-ups can be done @benjeffery? Otherwise, we'll end up having to implement full change in this PR I think. |
|
I've added a commit to disable these tests - if you agree with this course of action @benjeffery we should open an issue so we don't forget to turn them back on again. |
jeromekelleher
force-pushed
the
variable-size-offsets
branch
from
7fb0653 to
7677b2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
- Coverage 93.61% 93.60% -0.02%
==========================================
Files 27 27
Lines 22982 23033 +51
Branches 1079 1079
==========================================
+ Hits 21514 21559 +45
- Misses 1434 1440 +6
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This adds an intermediate step towards using 64 bit sizes internally.
jeromekelleher
force-pushed
the
variable-size-offsets
branch
from
7677b2b to
c9b0a6a
Compare
Stacked on #1552
This adds support for either 32 or 64 bit offsets in the file format and a new flag for dump that forces offsets to be 64 bit. This is an intermediate step towards having 64 bit offsets in memory. The TSK_DUMP_FORCE_OFFSET64 will be useful because it will allow us to test that we are loading correctly from 64 bit offset arrays in the kastore without needed to create huge metadata arrays.