Skip to content

Return unmodified schema from MD.schema #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

benjeffery
Copy link
Member

Fixes #3129

@benjeffery benjeffery force-pushed the fix-add-to-struct-schema branch from e7b6328 to e043227 Compare April 1, 2025 12:52
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (fc55565) to head (e043227).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3130   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files          29       29           
  Lines       32650    32651    +1     
  Branches     5854     5854           
=======================================
+ Hits        29367    29368    +1     
  Misses       1869     1869           
  Partials     1414     1414           
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.23% <ø> (ø)
python-tests 98.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/_version.py 100.00% <100.00%> (ø)
python/tskit/metadata.py 99.00% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Apr 1, 2025
@mergify mergify bot merged commit 44c7d7c into tskit-dev:main Apr 1, 2025
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Apr 1, 2025
@benjeffery benjeffery deleted the fix-add-to-struct-schema branch April 1, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.6.1 metadata.schema returns schema after codec.modify_schema
2 participants