Skip to content

tskit 0.4 seems to be breaking tszip tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianzhang01 opened this issue Jan 24, 2022 · 4 comments
Closed

tskit 0.4 seems to be breaking tszip tests #57

brianzhang01 opened this issue Jan 24, 2022 · 4 comments

Comments

@brianzhang01
Copy link
Member

The tszip tests were passing on Nov 8, 2021. Then sometime between then and Jan 20, 2022, they began failing. Here's the latest CI runs, showing 46 failing tests.

https://app.circleci.com/pipelines/github/tskit-dev/tszip/102/workflows/085bcc06-8109-4b39-b907-4ab8047524ff/jobs/104

During that window, tskit 0.4 was released: https://pypi.org/project/tskit/#history.

I ran some things locally that seem to suggest that tszip 0.2.0 works fine with tskit 0.3.7, but not with tskit 0.4.0. Therefore, I'm pinpointing it on some changes in tskit 0.4. For now, I'll just stick to tskit 0.3.7 until this is resolved.

@molpopgen
Copy link
Member

This is #54, I think.

@brianzhang01
Copy link
Member Author

Yes you're right, sorry about that.

@molpopgen
Copy link
Member

Yes you're right, sorry about that.

No worries.

@jeromekelleher
Copy link
Member

Thanks for the report @brianzhang01 - yes this is a dupe of #54, so going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants