Skip to content

Commit 6293e6d

Browse files
authored
Avoid returning None from get_field_related_model_cls (#1956)
#1495 updated `get_field_related_model_cls` to raise `UnregisteredModelError` rather than returning `None` for failure paths. However, None can still be returned if the initial retrieval of `related_model_cls` returns None. This patch adds a check to see if the initial retrieval has got a `None` and then raises the appropriate error rather than letting `None` be returned.
1 parent ddbc686 commit 6293e6d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

mypy_django_plugin/django/context.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,9 @@ def get_field_related_model_cls(self, field: Union["RelatedField[Any, Any]", For
369369
else:
370370
related_model_cls = field.field.model
371371

372+
if related_model_cls is None:
373+
raise UnregisteredModelError
374+
372375
if isinstance(related_model_cls, str):
373376
if related_model_cls == "self": # type: ignore[unreachable]
374377
# same model

0 commit comments

Comments
 (0)