From e800ef386e8bfec71908144f761616a58f3e817d Mon Sep 17 00:00:00 2001 From: Brian Helba Date: Tue, 12 Sep 2023 17:37:58 -0400 Subject: [PATCH 1/3] Fix broken tests caused by django-stubs 4.2.4 --- tests/typecheck/test_views.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/typecheck/test_views.yml b/tests/typecheck/test_views.yml index 6d6cae1fa..c83f8e149 100644 --- a/tests/typecheck/test_views.yml +++ b/tests/typecheck/test_views.yml @@ -16,7 +16,7 @@ pass class MyView(generics.DestroyAPIView): - queryset = MyModel.objects.all() + queryset = MyModel._default_manager.all() def perform_destroy(self, instance: MyModel) -> None: ... From 8970209597ccbacadab9d88ddc9afe7c5e6d7e70 Mon Sep 17 00:00:00 2001 From: Brian Helba Date: Tue, 12 Sep 2023 17:52:54 -0400 Subject: [PATCH 2/3] Add a field to empty test model Co-authored-by: Nikita Sobolev --- tests/typecheck/test_views.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/typecheck/test_views.yml b/tests/typecheck/test_views.yml index c83f8e149..877c1d097 100644 --- a/tests/typecheck/test_views.yml +++ b/tests/typecheck/test_views.yml @@ -13,10 +13,10 @@ from django.db.models import Model class MyModel(Model): - pass + field = models.IntegerField() class MyView(generics.DestroyAPIView): - queryset = MyModel._default_manager.all() + queryset = MyModel.objects.all() def perform_destroy(self, instance: MyModel) -> None: ... From 7815df147232827cc722356199893a056bda74a4 Mon Sep 17 00:00:00 2001 From: Brian Helba Date: Tue, 12 Sep 2023 18:01:47 -0400 Subject: [PATCH 3/3] Fix import in tests --- tests/typecheck/test_views.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/typecheck/test_views.yml b/tests/typecheck/test_views.yml index 877c1d097..7d2f0a3ac 100644 --- a/tests/typecheck/test_views.yml +++ b/tests/typecheck/test_views.yml @@ -10,9 +10,9 @@ - case: test_destroy_api_view main: | from rest_framework import generics - from django.db.models import Model + from django.db import models - class MyModel(Model): + class MyModel(models.Model): field = models.IntegerField() class MyView(generics.DestroyAPIView):