Bump create-react-app (#3)

* update: bump up cra

* fix: remove tslint and fix eslint warnings

Author: sisisin

package.json

@@ -14,21 +14,19 @@
     "react": "16.8.4",
     "react-app-rewired": "2.1.1",
     "react-dom": "16.8.4",
-    "react-scripts": "2.1.8",
+    "react-scripts": "3.0.1",
     "redux": "4.0.1",
     "redux-logger": "^3.0.6",
     "remeda": "^0.0.11",
     "rxjs": "6.2.2",
     "styled-components": "^4.1.3",
-    "tslint": "^5.14.0",
-    "tslint-config-prettier": "^1.18.0",
     "typeless": "0.0.18",
     "typescript": "^3.3.3333"
   },
   "scripts": {
     "prettier": "prettier --write 'src/**/*.{ts,tsx}'",
     "tsc": "tsc",
-    "lint": "tslint 'src/**/*.{ts,tsx}'",
+    "lint": "eslint --ext ts,tsx src",
     "start": "react-app-rewired start",
     "build": "react-app-rewired build",
     "test": "react-app-rewired test --env=jsdom",
@@ -43,5 +41,8 @@
   "prettier": {
     "singleQuote": true,
     "trailingComma": "es5"
+  },
+  "eslintConfig": {
+    "extends": "react-app"
   }
 }

src/components/Link.tsx

@@ -3,15 +3,15 @@ import { RouterActions } from 'src/features/router/interface';
 import { useActions } from 'typeless';
 
 interface LinkProps extends React.AnchorHTMLAttributes<HTMLAnchorElement> {
+  children: any;
   //
 }
 
-export const Link = (props: LinkProps) => {
-  const { href, onClick } = props;
+export const Link = ({ href, onClick, children, ...others }: LinkProps) => {
   const { push } = useActions(RouterActions);
   return (
     <a
-      {...props}
+      {...others}
       onClick={e => {
         e.preventDefault();
         if (href) {
@@ -21,6 +21,8 @@ export const Link = (props: LinkProps) => {
           onClick(e);
         }
       }}
-    />
+    >
+      {children}
+    </a>
   );
 };

src/components/RouteResolver.tsx

@@ -54,6 +54,8 @@ export const RouteResolver = () => {
     // not found route
     // you can display 404 or redirect to default routes
     push(user ? '/' : '/login');
+
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [location, user]);
 
   return component;

src/form/createForm.ts

@@ -59,8 +59,10 @@ export interface FormResult<TData, TState> {
     ) => { payload: { field: keyof TData }; meta: { form: string } };
     change: (
       field: keyof TData,
+      // eslint-disable-next-line no-undef
       value: TData[typeof field]
     ) => {
+      // eslint-disable-next-line no-undef
       payload: { field: keyof TData; value: TData[typeof field] };
       meta: { form: string };
     };

src/form/createFormProvider.tsx

@@ -18,6 +18,7 @@ export function createFormProvider<
         Object.assign({}, form, {
           actions: { blur, change },
         }),
+      // eslint-disable-next-line react-hooks/exhaustive-deps
       [form]
     );
 

src/hooks/usePrevious.ts

@@ -5,6 +5,8 @@ export function usePrevious<T>(value: T) {
 
   useEffect(() => {
     ref.current = value;
+
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [value]);
 
   return ref.current;