Refactor common parts of convertConfig and convertEditorConfig into runFileConversion helper #274
Labels
status: aged away
Not enough activity occurred on this issue in a reasonable amount of time to justify taking action.
type: cleanup
Code smells, incorrect tests, build systems, or other internal shenanigans
This is a follow-up issue of this PR: #250.
It is only valid if this branch gets merged.
Original discussion #250 (comment):
🚀 Feature Request
This refactoring should not touch the general functionality. The goal is to remove a good portion of copy-paste code. However it may involve a greater architectural change in order to handle rule conversions and editor settings conversions similar.
Existing Behavior
convertConfig.ts
converts TSLint rules into ESLint rulesconvertEditorConfig.ts
converts TSLint editor configuration settings into ESLint editor configuration settingsChange Proposal
The potential
runFileConversion
could extract the commonalities out of theconvertConfig
andconvertEditorConfig
. Mainly these steps are taken:The challenge is that the things to be done are quite similar, the data on which is operated differs in it's structure, e.g. the configuration that is read is of very different structures (rules files are typed very narrow, editor configuration settings are more unstructured)
The text was updated successfully, but these errors were encountered: