Skip to content

addPrettierExtensions doesn't need to be async #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Oct 3, 2020 · 0 comments · Fixed by #731
Closed

addPrettierExtensions doesn't need to be async #730

JoshuaKGoldberg opened this issue Oct 3, 2020 · 0 comments · Fixed by #731
Assignees
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Quick little tech debt point I just noticed while investigating #729: although other logic around rule extensions called by summarizePackageRules does need to be async, addPrettierExtensions itself makes no asynchronous calls. It can be changed to a non-async function.

The name also is a relic, I think, of an implementation draft that is no longer accurate. Maybe... checkPrettierExtension would be a better name for it? It doesn't add any extensions; it just checks whether the Prettier config should be extended from.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans labels Oct 3, 2020
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
1 participant