Skip to content

Preamble: If we start in the "code" mode, do we need to delimit the preamble? #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mihnita opened this issue May 11, 2022 · 3 comments
Closed
Labels
blocker Blocks the release resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. syntax Issues related with syntax or ABNF

Comments

@mihnita
Copy link
Collaborator

mihnita commented May 11, 2022

No description provided.

@mihnita mihnita added the syntax Issues related with syntax or ABNF label May 11, 2022
@mihnita
Copy link
Collaborator Author

mihnita commented May 12, 2022

Comments migrated from the slides

Start in text, delimit variants, use single brackets


Slides comment, Markus Scherer (@markusicu), 9:14 AM Apr 25

In principle, I am strongly in favor of B, but I would quibble with the specific syntax shown on the following slides.

For example, using square brackets means that they (or at least the closing one, better both) must be escaped. Consider sticking with curly braces.

The selector head should have some syntax, not just a nested list of selectors. I suggest {? selectors+ }.

@markusicu
Copy link
Member

While working on the compromise syntax, I changed my opinion compared to my older comment on the slide. I now favor starting in "code" mode and always delimiting patterns with {}. Within "code" mode, it is easy to give the syntax elements distinct prefixes, so we need not add another layer of delimiters there.

@stasm stasm added the resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. label Jun 1, 2022
@romulocintra
Copy link
Collaborator

Related/Redundant #252 #257

@romulocintra romulocintra closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocks the release resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. syntax Issues related with syntax or ABNF
Projects
None yet
Development

No branches or pull requests

4 participants