Skip to content
This repository was archived by the owner on Jul 19, 2022. It is now read-only.

Loading definitions from empty state doesn't show spinner #236

Closed
hojberg opened this issue Oct 4, 2021 · 0 comments · Fixed by #281
Closed

Loading definitions from empty state doesn't show spinner #236

hojberg opened this issue Oct 4, 2021 · 0 comments · Fixed by #281
Labels
bug Something isn't working C3 High Certainty E4 I2 Medium Impact R3 High Reach

Comments

@hojberg
Copy link
Member

hojberg commented Oct 4, 2021

Because we change the URL after the definition has been loaded and because we show the workspace only when a Definition route is matched, the first definition opened, doesn't have a spinner.

The better implementation is to change the way we load definitions; instead of loading and having the url change be a side-effect, It should be the other way around.
@hojberg hojberg added bug Something isn't working R3 High Reach E4 C3 High Certainty I2 Medium Impact labels Oct 4, 2021
@hojberg hojberg mentioned this issue Nov 30, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working C3 High Certainty E4 I2 Medium Impact R3 High Reach
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Definitions are opened via Route changes unisonweb/codebase-ui
1 participant
@hojberg