Skip to content
This repository was archived by the owner on Jul 16, 2022. It is now read-only.

Proper fsync on Windows #18

Closed
untitaker opened this issue Jul 26, 2016 · 3 comments
Closed

Proper fsync on Windows #18

untitaker opened this issue Jul 26, 2016 · 3 comments

Comments

@untitaker
Copy link
Owner

See #6. This blogpost covers this issue in great detail. For Windows, this is mentioned:

On Windows, using FlushFileBuffers() is probably the way to go.

Not really a confident statement, more research needed.

@untitaker
Copy link
Owner Author

We currently use _commit, which doesn't try to flush disk buffers. However, there is no indication that FlushFileBuffers is different in that regard.

@Dobatymo
Copy link

First: _commit calls FlushFileBuffers internally (according to https://stackoverflow.com/a/1947818). Second: Where do you actually call _commit?

@untitaker
Copy link
Owner Author

os.fsync is documented as calling _commit. I guess then this issue is not actionable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants