Skip to content

Docker built with Go 1.6 not supported #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Confusion opened this issue Jul 8, 2016 · 2 comments
Closed

Docker built with Go 1.6 not supported #415

Confusion opened this issue Jul 8, 2016 · 2 comments

Comments

@Confusion
Copy link

Confusion commented Jul 8, 2016

The current version of docker-api (1.29) is not compatible with e.g. the current docker.io (1.10.3) package in Ubuntu 16.04. The result of e.g. a Docker.info call is

400 Bad Request: malformed Host header

From rexray/rexray#317 and NVIDIA/nvidia-docker#83 you can surmise that the problem is that the docker in the package is built using Go 1.6.1 and there have been backwards incompatible changes to the Go http package.

Specifically, they are now checking the validity of the the Host header (related issue: golang/go#13624, from there you can follow to the commit that made the change). The problem is that docker-api sends /var/run/docker.sock as the Host header. This is not valid according to rfc 7230. This excon issue makes the case that the Host header should be empty.

Note that it seems that until now the Host field was effectively ignored by Go, so this change should be completely backwards compatible and especially should not affect compatibility with older versions.

BTW. docker-engine 1.10.3 in the Docker repos is built using Go 1.5.3 and works fine with 1.29

@Confusion Confusion changed the title Ubuntu 16.04 docker.io 10.1.3 not supported? Docker built with Go 1.6 not supported Jul 8, 2016
@tlunter
Copy link
Contributor

tlunter commented Jul 8, 2016

@Confusion 61a4497

This is noted in the README. If you update your version of excon, this shouldn't be an issue. Can you validate?

@Confusion
Copy link
Author

I can confirm that solves the issue.

I'm a bit surprised Google didn't turn up the README or referenced earlier issue as hits. Lesson learned: re-read READMEs when running into an issue you are pretty sure must have been encountered by many before you :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants