From c25936f7637a388698d369031088b4c13e0e16db Mon Sep 17 00:00:00 2001 From: vivian Date: Wed, 12 Feb 2025 16:50:47 +0530 Subject: [PATCH 1/6] added contiue-on-error as input in python-lint --- python-lint/action.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/python-lint/action.yml b/python-lint/action.yml index 2918e78..e2d6447 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -10,6 +10,11 @@ inputs: description: "The version of Poetry to use" required: true + continue-on-error: + description: "Continue on error" + required: false + default: "false" + runs: using: "composite" @@ -43,20 +48,20 @@ runs: - name: Run Black run: poetry run black --check . - continue-on-error: true #Added so to provide lineance while lint + continue-on-error: ${{ inputs.continue-on-error }} #Added so to provide lineance while lint shell: bash - name: Run Flake8 run: poetry run flake8 . - continue-on-error: true #Added so to provide lineance while lint + continue-on-error: ${{ inputs.continue-on-error }} #Added so to provide lineance while lint shell: bash - name: Run isort run: poetry run isort --check . - continue-on-error: true #Added so to provide lineance while lint + continue-on-error: ${{ inputs.continue-on-error }} #Added so to provide lineance while lint shell: bash - name: Run mypy run: poetry run mypy . - continue-on-error: true #Added so to provide lineance while lint + continue-on-error: ${{ inputs.continue-on-error }} #Added so to provide lineance while lint shell: bash From 1b0656fcbd2005c0476d9609751920618665a4cc Mon Sep 17 00:00:00 2001 From: vivian Date: Wed, 12 Feb 2025 17:10:58 +0530 Subject: [PATCH 2/6] added continue-on-error input on tests --- python-lint/action.yml | 2 +- python-test/action.yml | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/python-lint/action.yml b/python-lint/action.yml index e2d6447..1b3c673 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -13,7 +13,7 @@ inputs: continue-on-error: description: "Continue on error" required: false - default: "false" + default: false runs: using: "composite" diff --git a/python-test/action.yml b/python-test/action.yml index 229e3d5..8917aeb 100644 --- a/python-test/action.yml +++ b/python-test/action.yml @@ -8,6 +8,10 @@ inputs: poetry-version: description: "The version of Poetry to install" required: true + continue-on-error: + description: "Continue on error" + required: false + default: false runs: using: "composite" @@ -46,5 +50,5 @@ runs: - name: Run Test run: poetry run pytest - continue-on-error: true + continue-on-error: ${{ inputs.continue-on-error }} shell: bash From 774d162f791b8d44fdc005124aab72e87f0cbb25 Mon Sep 17 00:00:00 2001 From: vivian Date: Wed, 12 Feb 2025 19:04:30 +0530 Subject: [PATCH 3/6] set default value as true --- python-lint/action.yml | 2 +- python-test/action.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python-lint/action.yml b/python-lint/action.yml index 1b3c673..410c2a7 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -13,7 +13,7 @@ inputs: continue-on-error: description: "Continue on error" required: false - default: false + default: true runs: using: "composite" diff --git a/python-test/action.yml b/python-test/action.yml index 8917aeb..c02ae51 100644 --- a/python-test/action.yml +++ b/python-test/action.yml @@ -11,7 +11,7 @@ inputs: continue-on-error: description: "Continue on error" required: false - default: false + default: true runs: using: "composite" From 3d5f4099be219580ee6652dc8f400568717e0500 Mon Sep 17 00:00:00 2001 From: vivian Date: Wed, 12 Feb 2025 19:13:39 +0530 Subject: [PATCH 4/6] Updated default value from boolean to string --- python-lint/action.yml | 2 +- python-test/action.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python-lint/action.yml b/python-lint/action.yml index 410c2a7..7303eea 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -13,7 +13,7 @@ inputs: continue-on-error: description: "Continue on error" required: false - default: true + default: "true" runs: using: "composite" diff --git a/python-test/action.yml b/python-test/action.yml index c02ae51..2719645 100644 --- a/python-test/action.yml +++ b/python-test/action.yml @@ -11,7 +11,7 @@ inputs: continue-on-error: description: "Continue on error" required: false - default: true + default: "true" runs: using: "composite" From 931d13141ca8fd3dc0dd75e3c94cd7e3ba2dbb26 Mon Sep 17 00:00:00 2001 From: vivian Date: Thu, 13 Feb 2025 17:09:33 +0530 Subject: [PATCH 5/6] added type as boolean --- python-lint/action.yml | 1 + python-test/action.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/python-lint/action.yml b/python-lint/action.yml index 7303eea..54c9ade 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -11,6 +11,7 @@ inputs: required: true continue-on-error: + type: boolean description: "Continue on error" required: false default: "true" diff --git a/python-test/action.yml b/python-test/action.yml index 2719645..c8a0221 100644 --- a/python-test/action.yml +++ b/python-test/action.yml @@ -9,6 +9,7 @@ inputs: description: "The version of Poetry to install" required: true continue-on-error: + type: boolean description: "Continue on error" required: false default: "true" From f16db7f519e9fdef8de0f43e9e683258bb33084b Mon Sep 17 00:00:00 2001 From: vivian Date: Thu, 13 Feb 2025 17:18:32 +0530 Subject: [PATCH 6/6] updated default to boolean --- python-lint/action.yml | 2 +- python-test/action.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python-lint/action.yml b/python-lint/action.yml index 54c9ade..0a6e31c 100644 --- a/python-lint/action.yml +++ b/python-lint/action.yml @@ -14,7 +14,7 @@ inputs: type: boolean description: "Continue on error" required: false - default: "true" + default: true runs: using: "composite" diff --git a/python-test/action.yml b/python-test/action.yml index c8a0221..74c6c00 100644 --- a/python-test/action.yml +++ b/python-test/action.yml @@ -12,7 +12,7 @@ inputs: type: boolean description: "Continue on error" required: false - default: "true" + default: true runs: using: "composite"