From 56d376e0efdecef2d65e707e2f5a334a82a5074e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Inf=C3=BChr?= Date: Tue, 11 Feb 2020 12:50:05 +0100 Subject: [PATCH 1/2] No concurrent array buffer sweeping for some tests --- test/parallel/test-memory-usage.js | 2 +- test/parallel/test-zlib-unused-weak.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-memory-usage.js b/test/parallel/test-memory-usage.js index a1d07c64776068..4fad26753fdf3c 100644 --- a/test/parallel/test-memory-usage.js +++ b/test/parallel/test-memory-usage.js @@ -18,7 +18,7 @@ // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. - +// Flags: --no-concurrent-array-buffer-sweeping 'use strict'; const common = require('../common'); const assert = require('assert'); diff --git a/test/parallel/test-zlib-unused-weak.js b/test/parallel/test-zlib-unused-weak.js index 7a5a6728533e18..e74384eccf05c7 100644 --- a/test/parallel/test-zlib-unused-weak.js +++ b/test/parallel/test-zlib-unused-weak.js @@ -1,5 +1,5 @@ 'use strict'; -// Flags: --expose-gc +// Flags: --expose-gc --no-concurrent-array-buffer-sweeping require('../common'); const assert = require('assert'); const zlib = require('zlib'); From 4754b94d989f3e46f46fa564a4d3c781497294ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Inf=C3=BChr?= Date: Tue, 11 Feb 2020 16:46:52 +0100 Subject: [PATCH 2/2] skip tests until flag is supported --- test/parallel/parallel.status | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index e4983e7de5431b..ba4dba86a9f004 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -17,6 +17,10 @@ test-domain-error-types: SKIP test-v8-flags: SKIP test-vm-basic: SKIP test-http-pipeline-requests-connection-leak: SKIP +# Skip tests until --no-concurrent-array-buffer-sweeping is supported +# by the V8 version used in Node. +test-memory-usage: SKIP +test-zlib-unused-weak: SKIP [$system==win32] # https://github.com/nodejs/node/issues/20750