Skip to content

Commit 64ed94b

Browse files
committed
[FIX] requirements.txt: Fix maximum recursion in gevent
Using py3.6 and gevent==1.1.2 the following error could be reproduced in corner cases: File "/usr/lib/python3.6/ssl.py", line 485, in verify_mode super(SSLContext, SSLContext).verify_mode.__set__(self, value) File "/usr/lib/python3.6/ssl.py", line 485, in verify_mode super(SSLContext, SSLContext).verify_mode.__set__(self, value) File "/usr/lib/python3.6/ssl.py", line 485, in verify_mode super(SSLContext, SSLContext).verify_mode.__set__(self, value) [Previous line repeated 281 more times] RecursionError: maximum recursion depth exceeded But using any version gevent>1.1.2 the issue is not reproduced even gevent==1.2.0 The corner case to reproduced is the following: - Use py3.6 - install gevent==1.1.2 - Configure the reverse proxy - Use proxy e.g. nginx - `--longpolling-port` - `--workers>2` - Use Odoo>=12.0 - Install and configure [sentry module of the OCA](https://github.com/OCA/server-tools/tree/12.0/sentry) - Reload the /web page 2 times - See the logger error of maximum recursion - Now, install gevent==1.2.0 - Restart odoo-bin service - Reload the /web page 2 times again - See the logger and now it is not reproduced The gevent 1.1.2 version was assigned to be used in python3.5 But maybe for python3.6 we need bump it like python3.7 Issues related: - OCA/server-tools#1499 - gevent/gevent#1016 - getsentry/sentry#3384 - odoo#50861 - It was another corner case using py3.7 but they rolling backed to python 3.5 but maybe it could be reproduced in py3.6 too
1 parent b826c96 commit 64ed94b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

requirements.txt

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ decorator==4.0.10
44
docutils==0.12
55
ebaysdk==2.1.5
66
feedparser==5.2.1
7-
gevent==1.1.2 ; sys_platform != 'win32' and python_version < '3.7'
8-
gevent==1.5.0 ; python_version >= '3.7'
9-
greenlet==0.4.10 ; python_version < '3.7'
10-
greenlet==0.4.14 ; python_version >= '3.7'
7+
gevent==1.1.2 ; sys_platform != 'win32' and python_version < '3.6'
8+
gevent==1.5.0 ; python_version >= '3.6'
9+
greenlet==0.4.10 ; python_version < '3.6'
10+
greenlet==0.4.14 ; python_version >= '3.6'
1111
html2text==2016.9.19
1212
Jinja2==2.10.1
1313
libsass==0.12.3

0 commit comments

Comments
 (0)