From f7883913fbf724f6800458354aa5825fc5a2eb2b Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 12 Oct 2024 04:43:36 -0500 Subject: [PATCH 1/2] refactor!(tests) `skip_if_{vcs}_missing` -> `skip_if_missing_{vcs}` --- src/libvcs/pytest_plugin.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libvcs/pytest_plugin.py b/src/libvcs/pytest_plugin.py index 817a083f..fe89d187 100644 --- a/src/libvcs/pytest_plugin.py +++ b/src/libvcs/pytest_plugin.py @@ -30,15 +30,15 @@ def __init__(self, attempts: int, *args: object) -> None: ) -skip_if_git_missing = pytest.mark.skipif( +skip_if_missing_git = pytest.mark.skipif( not shutil.which("git"), reason="git is not available", ) -skip_if_svn_missing = pytest.mark.skipif( +skip_if_missing_svn = pytest.mark.skipif( not shutil.which("svn"), reason="svn is not available", ) -skip_if_hg_missing = pytest.mark.skipif( +skip_if_missing_hg = pytest.mark.skipif( not shutil.which("hg"), reason="hg is not available", ) @@ -109,7 +109,7 @@ def set_home( @pytest.fixture -@skip_if_git_missing +@skip_if_missing_git def gitconfig(user_path: pathlib.Path, set_home: pathlib.Path) -> pathlib.Path: """Return git configuration, pytest fixture.""" gitconfig = user_path / ".gitconfig" @@ -144,7 +144,7 @@ def gitconfig(user_path: pathlib.Path, set_home: pathlib.Path) -> pathlib.Path: @pytest.fixture -@skip_if_hg_missing +@skip_if_missing_hg def hgconfig(user_path: pathlib.Path, set_home: pathlib.Path) -> pathlib.Path: """Return Mercurial configuration, pytest fixture.""" hgrc = user_path / ".hgrc" @@ -256,7 +256,7 @@ def _create_git_remote_repo( @pytest.fixture -@skip_if_git_missing +@skip_if_missing_git def create_git_remote_repo( remote_repos_path: pathlib.Path, ) -> CreateRepoPytestFixtureFn: @@ -289,7 +289,7 @@ def git_remote_repo_single_commit_post_init(remote_repo_path: pathlib.Path) -> N @pytest.fixture -@skip_if_git_missing +@skip_if_missing_git def git_remote_repo(remote_repos_path: pathlib.Path) -> pathlib.Path: """Pre-made git repo w/ 1 commit, used as a file:// remote to clone and push to.""" return _create_git_remote_repo( @@ -341,7 +341,7 @@ def svn_remote_repo_single_commit_post_init(remote_repo_path: pathlib.Path) -> N @pytest.fixture -@skip_if_svn_missing +@skip_if_missing_svn def create_svn_remote_repo( remote_repos_path: pathlib.Path, ) -> CreateRepoPytestFixtureFn: @@ -366,7 +366,7 @@ def fn( @pytest.fixture -@skip_if_svn_missing +@skip_if_missing_svn def svn_remote_repo(remote_repos_path: pathlib.Path) -> pathlib.Path: """Pre-made. Local file:// based SVN server.""" return _create_svn_remote_repo( @@ -404,7 +404,7 @@ def hg_remote_repo_single_commit_post_init(remote_repo_path: pathlib.Path) -> No @pytest.fixture -@skip_if_hg_missing +@skip_if_missing_hg def create_hg_remote_repo( remote_repos_path: pathlib.Path, hgconfig: pathlib.Path, @@ -431,7 +431,7 @@ def fn( @pytest.fixture -@skip_if_hg_missing +@skip_if_missing_hg def hg_remote_repo( remote_repos_path: pathlib.Path, hgconfig: pathlib.Path, From 678737741ca1547c2b838050c4a5b62e14773c41 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Sat, 12 Oct 2024 08:31:17 -0500 Subject: [PATCH 2/2] docs(CHANGES) Note decorator rename --- CHANGES | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGES b/CHANGES index 1d8bdaa5..dc640c04 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,12 @@ $ pip install --user --upgrade --pre libvcs Renamed `git_local_clone` to `example_git_repo` for better understandability in documentation / doctests. +#### pytest plugin: Rename `skip_if_{vcs}_missing` -> `skip_if_missing_{vcs}` (#473) + +- `skip_if_git_missing` -> `skip_if_missing_git` +- `skip_if_hg_missing` -> `skip_if_missing_hg` +- `skip_if_svn_missing` -> `skip_if_missing_svn` + #### cmd: Listing method renamed (#466) - `libvcs.cmd.git.GitCmd._list()` -> `libvcs.cmd.git.Git.ls()`