Skip to content

Commit f56818d

Browse files
committed
Use react-dom directly instead of server-rendering-stub
No longer needed now that facebook/react#28271 exists
1 parent 6b077bc commit f56818d

File tree

4 files changed

+2
-9
lines changed

4 files changed

+2
-9
lines changed

packages/next/src/build/create-compiler-aliases.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,6 @@ export function createRSCAliases(
298298
alias[
299299
'react-dom$'
300300
] = `next/dist/compiled/react-dom${bundledReactChannel}/react-dom.react-server`
301-
} else {
302-
// x-ref: https://github.com/facebook/react/pull/25436
303-
alias[
304-
'react-dom$'
305-
] = `next/dist/compiled/react-dom${bundledReactChannel}/server-rendering-stub`
306301
}
307302
}
308303

packages/next/src/server/future/route-modules/app-page/vendored/ssr/entrypoints.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as React from 'react'
2-
import * as ReactDOM from 'react-dom/server-rendering-stub'
2+
import * as ReactDOM from 'react-dom'
33
import * as ReactJsxDevRuntime from 'react/jsx-dev-runtime'
44
import * as ReactJsxRuntime from 'react/jsx-runtime'
55

packages/next/types/react-dom.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
declare module 'react-dom/server-rendering-stub'
21
declare module 'react-dom/server.browser'
32

43
declare module 'react-dom/server.edge' {

packages/next/webpack.config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ function makeAppAliases(reactChannel = '') {
3333
return {
3434
react$: `next/dist/compiled/react${reactChannel}`,
3535
'react/react.react-server$': `next/dist/compiled/react${reactChannel}/react.react-server`,
36-
'react-dom/server-rendering-stub$': `next/dist/compiled/react-dom${reactChannel}/server-rendering-stub`,
37-
'react-dom$': `next/dist/compiled/react-dom${reactChannel}/server-rendering-stub`,
36+
'react-dom$': `next/dist/compiled/react-dom${reactChannel}`,
3837
'react/jsx-runtime$': `next/dist/compiled/react${reactChannel}/jsx-runtime`,
3938
'react/jsx-dev-runtime$': `next/dist/compiled/react${reactChannel}/jsx-dev-runtime`,
4039
'react-dom/client$': `next/dist/compiled/react-dom${reactChannel}/client`,

0 commit comments

Comments
 (0)