Fix crash after enabling MANIFEST parsing

DreierF · DreierF · commit d4009385fe54 · 2022-01-03T19:19:40.000+01:00
diff --git a/plugins/license-gather-plugin/src/main/kotlin/com/github/vlsi/gradle/license/GatherLicenseTask.kt b/plugins/license-gather-plugin/src/main/kotlin/com/github/vlsi/gradle/license/GatherLicenseTask.kt
@@ -500,7 +500,11 @@ open class GatherLicenseTask @Inject constructor(
             )
             JarFile(file).use { jar ->
                 val bundleLicense = jar.manifest.mainAttributes.getValue("Bundle-License")
-                val license = bundleLicense?.substringBefore(";")?.let {
+                if (bundleLicense == null || bundleLicense.startsWith("http://") || bundleLicense.startsWith("https://")) {
+                    // Ignore URLs here as it will fail during parsing
+                    return
+                }
+                val license = bundleLicense.substringBefore(";")?.let {
                     licenseExpressionParser.parse(it)
                 }
                 if (license != null) {

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,11 @@ open class GatherLicenseTask @Inject constructor(`
`500`	`500`	`)`
`501`	`501`	`JarFile(file).use { jar ->`
`502`	`502`	`val bundleLicense = jar.manifest.mainAttributes.getValue("Bundle-License")`
`503`		`- val license = bundleLicense?.substringBefore(";")?.let {`
	`503`	`+ if (bundleLicense == null \|\| bundleLicense.startsWith("http://") \|\| bundleLicense.startsWith("https://")) {`
	`504`	`+ // Ignore URLs here as it will fail during parsing`
	`505`	`+ return`
	`506`	`+ }`
	`507`	`+ val license = bundleLicense.substringBefore(";")?.let {`
`504`	`508`	`licenseExpressionParser.parse(it)`
`505`	`509`	`}`
`506`	`510`	`if (license != null) {`