Skip to content

Commit a45f237

Browse files
author
Greg Dubicki
committed
Improve comments
1 parent d8dd909 commit a45f237

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

manifests/pip.pp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@
239239

240240
'latest': {
241241
# Unfortunately this is the smartest way of getting the latest available package version with pip as of now
242+
# Note: we DO need to repeat ourselves with "from version" in both grep and sed as on some systems pip returns
243+
# more than one line with paretheses.
242244
$latest_version = join(["${pip_env} install ${proxy_flag} ${pkgname}==notreallyaversion 2>&1",
243245
' | grep -oP "\(from versions: .*\)" | sed -E "s/\(from versions: (.*?, )*(.*)\)/\2/g"',
244246
' | tr -d "[:space:]"'])

0 commit comments

Comments
 (0)