Add tsc-alias to dev dependencies. #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterliu1003
approved these changes
Jul 27, 2023
|
@Offlein Thank you so much for your contribution! It was merged and published in v4.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently upgraded to vfm 4.4.4.
In our latest version, our build process includes a failure because it cannot parse an alias in the Typescript definition:
I am not an expert on this but it appears to be because your CoreModalProps.ts file contains a reference with an alias in
it (
import type { ModalId, StyleValue } from '~/Modal'), but the vue-tsc build step does not extrapolate this for applications using this package as a dependencies.This adds tsc-alias to parse those out. Maybe the vue-final team prefers to address this another way (or maybe this is a non-issue that is our error), but if not, this should fix the issue.