Skip to content

Make vue/attribute-order rule fixable #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ota-meshi opened this issue Feb 22, 2018 · 4 comments
Closed

Make vue/attribute-order rule fixable #401

ota-meshi opened this issue Feb 22, 2018 · 4 comments
Labels
accepted proposition enhancement

Comments

@ota-meshi
Copy link
Member

Tell us about your environment

  • ESLint Version: 4.16.0
  • eslint-plugin-vue Version: 4.2.0
  • Node Version: 6.9.4

Question

I'd like to update vue/attribute-order#209 so that it can be auto fixable.
Are there any concerns about this?
For example, do I need to check the side effects caused by reordering in xml attributes?
@mysticatea
Copy link
Member

Thank you for this issue.

Sounds good to me.
I believe HTML attributes don't depend on the order.

@ota-meshi ota-meshi mentioned this issue Feb 23, 2018
Merged
@ota-meshi
Copy link
Member Author

thank you for your answer!
I did a PR. #405

@samit4me
Copy link

Really looking forward to seeing this one, nice work @ota-meshi 👏

@ota-meshi
Copy link
Member Author

#405 merged. so I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted proposition enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mysticatea @samit4me @ota-meshi