Skip to content

Commit 19e1c40

Browse files
committed
fix: server broken by circular tsconfig project reference
close #525, close #631, close #632
1 parent 5f9d132 commit 19e1c40

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/server/src/project.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ export function createProject(
138138
schemaRequestService: options.languageFeatures?.schemaRequestService ? getSchemaRequestService(connection, options.languageFeatures.schemaRequestService) : undefined,
139139
getPreferences: lsConfigs?.getTsPreferences,
140140
getFormatOptions: lsConfigs?.getTsFormatOptions,
141-
getParsedCommandLine: () => parsedCommandLine,
142141
getCssLanguageSettings: lsConfigs?.getCssLanguageSettings,
143142
// ts
144143
getHtmlHoverSettings: lsConfigs?.getHtmlHoverSettings,
@@ -151,7 +150,7 @@ export function createProject(
151150
readDirectory: ts.sys.readDirectory,
152151
realpath: ts.sys.realpath,
153152
fileExists: ts.sys.fileExists,
154-
getProjectReferences: () => parsedCommandLine.projectReferences,
153+
getProjectReferences: () => parsedCommandLine.projectReferences, // if circular, broken with provide `getParsedCommandLine: () => parsedCommandLine`
155154
// custom
156155
getDefaultLibFileName: options => ts.getDefaultLibFilePath(options), // TODO: vscode option for ts lib
157156
getProjectVersion: () => tsProjectVersion.toString(),

0 commit comments

Comments
 (0)