refactor: remove splice as sort mutates array

BobbieGoede · BobbieGoede · commit 2b3c39838361 · 2024-02-08T11:37:14.000+01:00
diff --git a/packages/router/src/matcher/index.ts b/packages/router/src/matcher/index.ts
@@ -366,17 +366,15 @@ export function createRouterMatcher(
   // restore matcher order from cache
   if (globalOptions.sortCache != null) {
     try {
-      const sorted = matchers.sort(
+      matchers.sort(
         (a, b) =>
           globalOptions!.sortCache![a.cacheKey!] -
           globalOptions!.sortCache![b.cacheKey!]
       )
 
-      for (const entry of sorted) {
+      for (const entry of matchers) {
         delete entry.cacheKey
       }
-
-      matchers.splice(0, matchers.length, ...sorted)
     } catch {
       console.log('Restore failure.')
     }

Original file line number	Diff line number	Diff line change
`@@ -366,17 +366,15 @@ export function createRouterMatcher(`
`366`	`366`	`// restore matcher order from cache`
`367`	`367`	`if (globalOptions.sortCache != null) {`
`368`	`368`	`try {`
`369`		`- const sorted = matchers.sort(`
	`369`	`+ matchers.sort(`
`370`	`370`	`(a, b) =>`
`371`	`371`	`globalOptions!.sortCache![a.cacheKey!] -`
`372`	`372`	`globalOptions!.sortCache![b.cacheKey!]`
`373`	`373`	`)`
`374`	`374`
`375`		`- for (const entry of sorted) {`
	`375`	`+ for (const entry of matchers) {`
`376`	`376`	`delete entry.cacheKey`
`377`	`377`	`}`
`378`		`-`
`379`		`- matchers.splice(0, matchers.length, ...sorted)`
`380`	`378`	`} catch {`
`381`	`379`	`console.log('Restore failure.')`
`382`	`380`	`}`