-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Allow relative sockjs URL #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose building |
/cc @jkzing |
I think this would be useful, not sure why we wouldn't want this to be able to be relative |
@sickp How to use devServer.public to build relative url? |
What problem does this feature solve?
I am using Nginx in development to terminate SSL and proxy to the dev-server (https://nginx/ => http://devserver:8080/) with
devServer.public
set appropriately, so I can use HTTPS/HTTP2 during development.This had been working fine until beta16 commit:
2cbe373
which makes sockjs URL absolute with the wrong host/port, now in this case:
https://10.0.1.6:8080/sockjs-node
. Previously it was simply/sockjs-node
.I would like an option to either specify
sockjsUrl
explicitly OR an option to omit the protocol/host/port and just use the pathname/sockjs-node
.What does the proposed API look like?
The text was updated successfully, but these errors were encountered: