Skip to content

UI should prevent from entering an invalid project name #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoispag opened this issue Jun 16, 2018 · 12 comments
Closed

UI should prevent from entering an invalid project name #1596

zoispag opened this issue Jun 16, 2018 · 12 comments

Comments

@zoispag
Copy link

zoispag commented Jun 16, 2018

Version

3.0.0-rc.2

Reproduction link

https://jsfiddle.net/zoispag/rba9coxn/

Steps to reproduce

  • Open vue-ui.
  • Create project with any preset
  • Choose either yarn or npm.

What is expected?

To create/download the project

What is actually happening?

Response in terminal
{"type":"error","data":"package.json: Name contains illegal characters"} command failed: yarn --json


Package.json contains:

{
  "name": "Projects/vueSpa",
  "version": "0.1.0",
  "private": true,
  "devDependencies": {
    "@vue/cli-plugin-babel": "^3.0.0-beta.15",
    "@vue/cli-plugin-eslint": "^3.0.0-beta.15",
    "@vue/cli-service": "^3.0.0-beta.15"
  }
}
@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

You shouldn't put a / in your project name.

@Akryum Akryum changed the title vue-ui hangs with error regarding package.json UI should preve'nt from entering an invalid project name Jun 16, 2018
@Akryum Akryum changed the title UI should preve'nt from entering an invalid project name UI should prevent from entering an invalid project name Jun 16, 2018
@zoispag
Copy link
Author

zoispag commented Jun 16, 2018

Thanks for your immediate response. I didn't want to put a / in my project name, rather that creating the project inside ~/Projects/projectname/ but it wouldn't allow me to choose a path.

@zoispag
Copy link
Author

zoispag commented Jun 16, 2018

Ok. I just realised how UI works. You have to run vue ui from dir where you want to create your project!

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

You can choose which folder you want to create the project in via the UI.

@zoispag
Copy link
Author

zoispag commented Jun 16, 2018

I started UI in ~ and I couldn't navigate to child dirs from inside ui. Only to parent.
Maybe this is something worth investigating.

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

Did you have any error in the browser console or the terminal?

@zoispag
Copy link
Author

zoispag commented Jun 16, 2018

Unfortunately no errors.

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

Could you try with vue ui -D and see if there are errors?

@zoispag
Copy link
Author

zoispag commented Jun 16, 2018

I get no errors in the console, but I get an "error" in the ui.
image

I can't select my user to go to ~ path.

Does this help?

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

What's the error in the browser console?

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

I added name validation in 8957c3a

@Akryum
Copy link
Member

Akryum commented Jun 16, 2018

Let's continue here: #1599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants