Skip to content

Commit 42a153a

Browse files
committed
feat(visible): Add visible() method on Wrapper (#327)
1 parent dd270b6 commit 42a153a

File tree

13 files changed

+268
-1
lines changed

13 files changed

+268
-1
lines changed

dist/vue-test-utils.js

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,12 @@ WrapperArray.prototype.exists = function exists () {
419419
return this.length > 0 && this.wrappers.every(function (wrapper) { return wrapper.exists(); })
420420
};
421421

422+
WrapperArray.prototype.visible = function visible () {
423+
this.throwErrorIfWrappersIsEmpty('visible');
424+
425+
return this.length > 0 && this.wrappers.every(function (wrapper) { return wrapper.visible(); })
426+
};
427+
422428
WrapperArray.prototype.emitted = function emitted () {
423429
this.throwErrorIfWrappersIsEmpty('emitted');
424430

@@ -590,6 +596,10 @@ ErrorWrapper.prototype.exists = function exists () {
590596
return false
591597
};
592598

599+
ErrorWrapper.prototype.visible = function visible () {
600+
throwError(("find did not return " + (this.selector) + ", cannot call visible() on empty Wrapper"));
601+
};
602+
593603
ErrorWrapper.prototype.hasAttribute = function hasAttribute () {
594604
throwError(("find did not return " + (this.selector) + ", cannot call hasAttribute() on empty Wrapper"));
595605
};
@@ -874,6 +884,26 @@ Wrapper.prototype.exists = function exists () {
874884
return true
875885
};
876886

887+
/**
888+
* Utility to check wrapper is visible. Returns false if a parent element has display: none or visibility: hidden style.
889+
*/
890+
Wrapper.prototype.visible = function visible () {
891+
var element = this.element;
892+
893+
if (!element) {
894+
return false
895+
}
896+
897+
while (element) {
898+
if (element.style && (element.style.visibility === 'hidden' || element.style.display === 'none')) {
899+
return false
900+
}
901+
element = element.parentElement;
902+
}
903+
904+
return true
905+
};
906+
877907
/**
878908
* Checks if wrapper has an attribute with matching value
879909
*/

docs/en/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
* [text](api/wrapper/text.md)
5353
* [trigger](api/wrapper/trigger.md)
5454
* [update](api/wrapper/update.md)
55+
* [visible](api/wrapper/visible.md)
5556
* [WrapperArray](api/wrapper-array/README.md)
5657
* [at](api/wrapper-array/at.md)
5758
* [contains](api/wrapper-array/contains.md)
@@ -67,6 +68,7 @@
6768
* [setProps](api/wrapper-array/setProps.md)
6869
* [trigger](api/wrapper-array/trigger.md)
6970
* [update](api/wrapper-array/update.md)
71+
* [visible](api/wrapper-array/visible.md)
7072
* [components](api/components/README.md)
7173
* [TransitionStub](api/components/TransitionStub.md)
7274
* [TransitionGroupStub](api/components/TransitionGroupStub.md)

docs/en/SUMMARY.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
* [text](api/wrapper/text.md)
4949
* [trigger](api/wrapper/trigger.md)
5050
* [update](api/wrapper/update.md)
51+
* [visible](api/wrapper/visible.md)
5152
* [WrapperArray](api/wrapper-array/README.md)
5253
* [at](api/wrapper-array/at.md)
5354
* [contains](api/wrapper-array/contains.md)
@@ -63,6 +64,7 @@
6364
* [setProps](api/wrapper-array/setProps.md)
6465
* [trigger](api/wrapper-array/trigger.md)
6566
* [update](api/wrapper-array/update.md)
67+
* [visible](api/wrapper-array/visible.md)
6668
* [components](api/components/README.md)
6769
* [TransitionStub](api/components/TransitionStub.md)
6870
* [TransitionGroupStub](api/components/TransitionGroupStub.md)

docs/en/api/wrapper-array/visible.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# visible()
2+
3+
Assert every `Wrapper` in `WrapperArray` is visible.
4+
5+
Returns false if at least one ancestor element has `display: none` or `visibility: hidden` style.
6+
7+
This can be used to assert that a component is hidden by `v-show`.
8+
9+
- **Returns:** `{boolean}`
10+
11+
- **Example:**
12+
13+
```js
14+
import { mount } from 'vue-test-utils'
15+
import { expect } from 'chai'
16+
import Foo from './Foo.vue'
17+
18+
const wrapper = mount(Foo)
19+
expect(wrapper.visible()).toBe(true)
20+
expect(wrapper.findAll('.is-not-visible').visible()).toBe(false)
21+
expect(wrapper.findAll('.is-visible').visible()).toBe(true)
22+
```

docs/en/api/wrapper/visible.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# visible()
2+
3+
Assert `Wrapper` or `WrapperArray` is visible.
4+
5+
Returns false if an ancestor element has `display: none` or `visibility: hidden` style.
6+
7+
This can be used to assert that a component is hidden by `v-show`.
8+
9+
- **Returns:** `{boolean}`
10+
11+
- **Example:**
12+
13+
```js
14+
import { mount } from 'vue-test-utils'
15+
import { expect } from 'chai'
16+
import Foo from './Foo.vue'
17+
18+
const wrapper = mount(Foo)
19+
expect(wrapper.visible()).toBe(true)
20+
expect(wrapper.find('.is-not-visible').visible()).toBe(false)
21+
expect(wrapper.findAll('div').visible()).toBe(true)
22+
expect(wrapper.findAll('.is-not-visible').visible()).toBe(false)
23+
```

flow/wrapper.flow.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ declare interface BaseWrapper { // eslint-disable-line no-undef
1313
emitted(event?: string): { [name: string]: Array<Array<any>> } | Array<Array<any>> | void,
1414
emittedByOrder(): Array<{ name: string; args: Array<any> }> | void,
1515
exists(): boolean,
16+
visible(): boolean | void,
1617
hasAttribute(attribute: string, value: string): boolean | void,
1718
hasClass(className: string): boolean | void,
1819
hasProp(prop: string, value: string): boolean | void,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
],
1111
"scripts": {
1212
"build": "node build/build.js",
13-
"build:test": "NODE_ENV=test node build/build.js",
13+
"build:test": "cross-env NODE_ENV=test node build/build.js",
1414
"coverage": "cross-env NODE_ENV=coverage nyc --reporter=lcov --reporter=text npm run test:unit",
1515
"docs": "cd docs && gitbook install && gitbook serve",
1616
"docs:deploy": "build/update-docs.sh",

src/wrappers/error-wrapper.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ export default class ErrorWrapper implements BaseWrapper {
3636
return false
3737
}
3838

39+
visible (): void {
40+
throwError(`find did not return ${this.selector}, cannot call visible() on empty Wrapper`)
41+
}
42+
3943
hasAttribute (): void {
4044
throwError(`find did not return ${this.selector}, cannot call hasAttribute() on empty Wrapper`)
4145
}

src/wrappers/wrapper-array.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ export default class WrapperArray implements BaseWrapper {
4242
return this.length > 0 && this.wrappers.every(wrapper => wrapper.exists())
4343
}
4444

45+
visible (): boolean {
46+
this.throwErrorIfWrappersIsEmpty('visible')
47+
48+
return this.length > 0 && this.wrappers.every(wrapper => wrapper.visible())
49+
}
50+
4551
emitted (): void {
4652
this.throwErrorIfWrappersIsEmpty('emitted')
4753

src/wrappers/wrapper.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,26 @@ export default class Wrapper implements BaseWrapper {
120120
return true
121121
}
122122

123+
/**
124+
* Utility to check wrapper is visible. Returns false if a parent element has display: none or visibility: hidden style.
125+
*/
126+
visible (): boolean {
127+
let element = this.element
128+
129+
if (!element) {
130+
return false
131+
}
132+
133+
while (element) {
134+
if (element.style && (element.style.visibility === 'hidden' || element.style.display === 'none')) {
135+
return false
136+
}
137+
element = element.parentElement
138+
}
139+
140+
return true
141+
}
142+
123143
/**
124144
* Checks if wrapper has an attribute with matching value
125145
*/

0 commit comments

Comments
 (0)