From d6d22f6becf4a6e6966a15cd1fed34f8b872cea7 Mon Sep 17 00:00:00 2001 From: LocTran Date: Mon, 31 Aug 2020 18:43:50 +0700 Subject: [PATCH 1/2] Update deploy.md Here is my issue: https://github.com/vuejs/vuepress/issues/2584 I've found that node:9.11.1 is too old and in the `Prerequisites` part of the guide, it's recommend to use node 10+ so update a small comment could be useful. I don't know if it is applicable to delete `node:9.11.1` and replace with `node:14.8.0` so I just add a comment --- packages/docs/docs/guide/deploy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docs/docs/guide/deploy.md b/packages/docs/docs/guide/deploy.md index a5d804a84f..d5eb910678 100644 --- a/packages/docs/docs/guide/deploy.md +++ b/packages/docs/docs/guide/deploy.md @@ -101,7 +101,7 @@ deploy: 3. Create a file called `.gitlab-ci.yml` in the root of your project with the content below. This will build and deploy your site whenever you make changes to your content: ``` yaml -image: node:9.11.1 +image: node:9.11.1 # This is the enviroment going to be used for building and deploying, in some case, there will be errors with node version 9.11.1 so I recommend you to change into image: node:14.8.0 when there is some error pages: cache: From 244113b028316f88ee19dc1f98313ce9fa8980d1 Mon Sep 17 00:00:00 2001 From: LocTran Date: Tue, 1 Sep 2020 11:46:47 +0700 Subject: [PATCH 2/2] Update deploy.md --- packages/docs/docs/guide/deploy.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/docs/docs/guide/deploy.md b/packages/docs/docs/guide/deploy.md index d5eb910678..c7b0c3cad4 100644 --- a/packages/docs/docs/guide/deploy.md +++ b/packages/docs/docs/guide/deploy.md @@ -101,8 +101,7 @@ deploy: 3. Create a file called `.gitlab-ci.yml` in the root of your project with the content below. This will build and deploy your site whenever you make changes to your content: ``` yaml -image: node:9.11.1 # This is the enviroment going to be used for building and deploying, in some case, there will be errors with node version 9.11.1 so I recommend you to change into image: node:14.8.0 when there is some error - +image: node:10.22.0 pages: cache: paths: