Skip to content

where will we pass the second param cb for wrappedActionHandler? #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tinyCucumber opened this issue Jul 9, 2019 · 0 comments · Fixed by #1640
Closed

where will we pass the second param cb for wrappedActionHandler? #1578

tinyCucumber opened this issue Jul 9, 2019 · 0 comments · Fixed by #1640

Comments

@tinyCucumber
Copy link

Version

3.1.1

Reproduction link

https://codepen.io/cucumbers/pen/bPQQeO

Steps to reproduce

in the function registerAction, we will wrap the true handler and push into entry.And the wrapped handler receive two params - payload and cb. But what we can see in function dispatch is that the second param cb will never be passed in.

What is expected?

If the param cb is useless, remove it.

What is actually happening?

The param cb for wrappedActionHandler is never used;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant