Skip to content

"if client is an environment" is always true #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isonmad opened this issue Jan 3, 2017 · 3 comments
Closed

"if client is an environment" is always true #1045

isonmad opened this issue Jan 3, 2017 · 3 comments

Comments

@isonmad
Copy link
Contributor

isonmad commented Jan 3, 2017

4ce01b5#diff-27b79860afe28f01aed4f1f6228367faR1278 added if-else steps in several places in the wrong order, where it probably meant to be checking if client is the more specific category (an environment settings object) first, like 8b483b0#diff-27b79860afe28f01aed4f1f6228367faR3533 did -- because "if client is an environment" is always true regardless.

@jungkees
Copy link
Collaborator

jungkees commented Jan 3, 2017

Note that 4ce01b5#diff-27b79860afe28f01aed4f1f6228367faR1278 is different from "if client is an environment". It checks the type of the concept as "If client is a type of environment".

@isonmad
Copy link
Contributor Author

isonmad commented Jan 16, 2017

What's the practical difference, exactly? Don't those mean the same thing here?

@annevk
Copy link
Member

annevk commented Jan 16, 2017

I tend to agree with @isonmad. E.g., we use something like "if X is an element" fairly often in DOM and it needs to be true even if X is a subclass of Element. At some point we'll formalize this through brands: whatwg/webidl#97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants